Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IDGenerator for ID columns #1538

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Use IDGenerator for ID columns #1538

merged 7 commits into from
Aug 17, 2023

Conversation

frances-h
Copy link
Contributor

Resolve #1519

@frances-h frances-h self-assigned this Aug 14, 2023
@frances-h frances-h requested a review from a team as a code owner August 14, 2023 13:29
@frances-h frances-h requested review from amontanez24 and removed request for a team August 14, 2023 13:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (72f7e1f) 96.42% compared to head (4485120) 96.43%.
Report is 7 commits behind head on master.

❗ Current head 4485120 differs from pull request most recent head 90cf128. Consider uploading reports for the commit 90cf128 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   96.42%   96.43%           
=======================================
  Files          49       49           
  Lines        3999     4008    +9     
=======================================
+ Hits         3856     3865    +9     
  Misses        143      143
Files Changed Coverage Δ
sdv/data_processing/data_processor.py 97.07% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frances-h frances-h marked this pull request as draft August 14, 2023 13:43
amontanez24
amontanez24 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdv/data_processing/data_processor.py Outdated Show resolved Hide resolved
@frances-h frances-h marked this pull request as ready for review August 17, 2023 19:09
@frances-h frances-h requested a review from fealho August 17, 2023 19:09
fealho
fealho approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

sdv/data_processing/data_processor.py Show resolved Hide resolved
@frances-h frances-h merged commit 473ecee into master Aug 17, 2023
37 checks passed
@frances-h frances-h deleted the issue-1519-use-IDGenerator branch August 17, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@fealho fealho fealho approved these changes

Assignees

@frances-h frances-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use IDGenerator for ID columns
4 participants
@frances-h @codecov-commenter @amontanez24 @fealho